Skip to content

Add new functions to analyze deepDiff results in parameter variation cases [com1]#945

Merged
fso42 merged 1 commit intomasterfrom
issue814
Dec 5, 2023
Merged

Add new functions to analyze deepDiff results in parameter variation cases [com1]#945
fso42 merged 1 commit intomasterfrom
issue814

Conversation

@fso42
Copy link
Copy Markdown
Contributor

@fso42 fso42 commented Nov 28, 2023

fixes #814

@fso42 fso42 added the confirmed Something isn't working label Nov 28, 2023
@fso42 fso42 added this to the Version 1.8 milestone Nov 28, 2023
@fso42 fso42 self-assigned this Nov 28, 2023
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Nov 28, 2023

Hello @fso42! Thanks for updating this PR.

Line 1590:121: E501 line too long (136 > 120 characters)
Line 611:45: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 597:18: E711 comparison to None should be 'if cond is not None:'

Line 184:29: E721 do not compare types, use 'isinstance()'

Comment last updated at 2023-11-30 13:50:52 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4ec4c4a) 74.66% compared to head (3d4b856) 74.70%.

Files Patch % Lines
avaframe/com1DFA/com1DFATools.py 92.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   74.66%   74.70%   +0.03%     
==========================================
  Files          64       64              
  Lines       14629    14649      +20     
==========================================
+ Hits        10923    10943      +20     
  Misses       3706     3706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 3d4b856 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.7% (0.1% change).

View more on Code Climate.

@fso42 fso42 merged commit 969b488 into master Dec 5, 2023
@fso42 fso42 deleted the issue814 branch December 5, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding variation to a parameter leads to wrong default indicator

3 participants