Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
==========================================
- Coverage 73.92% 73.88% -0.05%
==========================================
Files 64 64
Lines 14675 14755 +80
==========================================
+ Hits 10848 10901 +53
- Misses 3827 3854 +27 ☔ View full report in Codecov by Sentry. |
|
Hello @awirb! Thanks for updating this PR.
Comment last updated at 2024-01-23 15:49:26 UTC |
fso42
left a comment
There was a problem hiding this comment.
I think it would be necessary to explain the override logic in our documentation...
- add function to create local cfg files with overrides - add collection name to override section
- move writing of local cfgs to folder
|
Code Climate has analyzed commit cb67a4b and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 76.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 73.8% (-0.1% change). View more on Code Climate. |
|
Standardtests ok, apart from avaKot |
|
avaKot is related to change here: #948, accepting for now (new DEM data basis, reporjection ...). Benchmark results need to be updated. |
Breaking change for override sections: now need the collection name as well as the module name