Reverse PreDestroy Order based on constructor dependency order #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all things be equal will execute predestroy hooks in reverse order
rbygrave
approved these changes
Aug 9, 2025
rbygrave
added
bug
rbygrave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, all things being equal, will execute pre-destroy hooks in reverse registration order.
Resolves #880
Rob note: The
registration orderin practice is based on constructor dependencies, so as long as constructor injection is used, then the ordering of the associated@PreDestroyis deterministic and now the reverse of that.However, if constructor injection is NOT used, then the ordering is not as deterministic and in this case we need to use explicit
priorityon the@PreDestroyto guarantee the correct ordering.