Skip to content

Throw compile error for nested factory #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

Throw compile error for nested factory #927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
525cd45
Throw compile error for nested factory
SentryMan Nov 19, 2025
36fc131
Merge branch 'master' into no-nested-factory
rbygrave Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions inject-generator/src/main/java/io/avaje/inject/generator/InjectProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import javax.lang.model.element.Element;
import javax.lang.model.element.ElementKind;
import javax.lang.model.element.ExecutableElement;
import javax.lang.model.element.NestingKind;
import javax.lang.model.element.TypeElement;
import javax.lang.model.util.ElementFilter;
import javax.lang.model.util.Elements;
Expand Down Expand Up @@ -322,6 +323,9 @@ private void readChangedBeans(Set<TypeElement> beans, boolean factory, boolean i
if (typeElement.getKind() == ElementKind.INTERFACE) {
continue;
}
if (factory && typeElement.getNestingKind() != NestingKind.TOP_LEVEL) {
logError(typeElement, "@Factory Classes cannot be nested");
}
final var scope = findScope(typeElement);
if (!factory) {
// will be found via custom scope so effectively ignore additional @Singleton
Expand Down