Skip to content

Only Log Cascade Warning when in the Same Module #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2025
Merged

Only Log Cascade Warning when in the Same Module #439

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e1ae3fe
only log cascade warning if in the same module
SentryMan Oct 7, 2025
a6cd3d4
Update TypeReader.java
SentryMan Oct 7, 2025
c739357
Update TypeReader.java
SentryMan Oct 7, 2025
dc9a976
Update TypeReader.java
SentryMan Oct 7, 2025
60a8f27
Revert "Update TypeReader.java"
SentryMan Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions jsonb-generator/src/main/java/io/avaje/jsonb/generator/TypeReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,15 @@ private void matchFieldToSetter(FieldReader field) {
field.setUseGetterAddAll();
} else if (ProcessingContext.isCascadeType(baseType)) {
nonAccessibleField = true;
logWarn(field.element(), errorContext + baseType + ", non public field %s with no matching setter or constructor?", field.fieldName());

var module = APContext.getProjectModuleElement();
if (!module.isUnnamed() && module.equals(APContext.elements().getModuleOf(baseType))) {
logWarn(
field.element(),
"%s%s, non public field %s with no matching setter or constructor?",
errorContext,
baseType,
field.fieldName());
}
} else {
logError(field.element(), errorContext + baseType + ", non public field %s with no matching setter or constructor?", field.fieldName());
}
Expand Down