Skip to content

Conversation

@SentryMan
Copy link
Collaborator

resolves #442

@SentryMan SentryMan added this to the 3.8 milestone Oct 12, 2025
@SentryMan SentryMan self-assigned this Oct 12, 2025
@SentryMan SentryMan added the bug Something isn't working label Oct 12, 2025
Copy link
Contributor

@mechite mechite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debatably could be worth adding test, e.g.,

class JacksonAdapterFactoryTest {

  @Test
  void serviceLoader_jacksonAdapter() {
    Jsonb jsonb = Jsonb.instance();
    var input = new ByteArrayInputStream(new byte[0]);
    var output = new ByteArrayOutputStream();

    assertThat(jsonb.reader(input)).isInstanceOf(JacksonReader.class);
    assertThat(jsonb.writer(output)).isInstanceOf(JacksonWriter.class);
  }
}

@SentryMan SentryMan enabled auto-merge (squash) October 12, 2025 03:07
@SentryMan SentryMan merged commit 1fdfa59 into avaje:main Oct 14, 2025
5 of 6 checks passed
@SentryMan SentryMan deleted the jack branch October 14, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jsonb-jackson not automagically registering

3 participants