Resolve strict checking of function call arity #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novemberborn
requested changes
Jul 12, 2017
Member
novemberborn
left a comment
novemberborn
left a comment
There was a problem hiding this comment.
Hey @ajtorres9 thanks for this PR.
This does fix our regression tests, but the test() function should accept any number of arguments of any type after the test implementation. We should try and support that instead.
Contributor
Author
|
Hey @novemberborn I updated the feature branch to accommodate your requested changes. Thanks for the feedback. 👍 |
novemberborn
approved these changes
Jul 13, 2017
Member
|
Wonderful. I've cleaned up the |
Member
|
Thanks @ajtorres9! |
kevva
pushed a commit
that referenced
this pull request
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1423
NOTE: The ticket states the error occurred when upgrading to
flow-bin@0.48.0, but as I was addressing the issue the latest version was0.49.1. I verified the issue still occurred when usingflow-bin@0.49.1and updated thepackage.jsonfile accordingly.