New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support @std/esm #1618

Merged
merged 5 commits into from Jan 8, 2018

Conversation

Projects
None yet
4 participants
@jamestalmage
Contributor

jamestalmage commented Dec 23, 2017

This fixes support for @std/esm.

//cc: @jdalton

@motss motss referenced this pull request Dec 24, 2017

Merged

Add ES Modules recipe #1593

@novemberborn

@jamestalmage just so I understand, this detects the @std/esm require and replaces the require() method we use for other "require" values?

Is there a remaining issue with how we load the transpiled test files, or how we transpile them to begin with?

Show outdated Hide outdated lib/test-worker.js
@jamestalmage

This comment has been minimized.

Show comment
Hide comment
@jamestalmage

jamestalmage Dec 24, 2017

Contributor

@novemberborn - The only other issue would be providing a way to bypass the main thread precompilation. In that case, the package sniffing I am doing wouldn't be needed.

Contributor

jamestalmage commented Dec 24, 2017

@novemberborn - The only other issue would be providing a way to bypass the main thread precompilation. In that case, the package sniffing I am doing wouldn't be needed.

@jamestalmage

This comment has been minimized.

Show comment
Hide comment
@jamestalmage

jamestalmage Dec 24, 2017

Contributor

It also replaces "require" for when we load the tests.

Contributor

jamestalmage commented Dec 24, 2017

It also replaces "require" for when we load the tests.

@billyjanitsch

This comment has been minimized.

Show comment
Hide comment
@billyjanitsch

billyjanitsch Dec 24, 2017

Contributor

(Apologies for the notification spam.) As the original reporter of standard-things/esm#197, I just want to express appreciation for everyone working on this. Always awesome to see OSS projects come together to support interoperability for users. Thanks y'all ❤️

Contributor

billyjanitsch commented Dec 24, 2017

(Apologies for the notification spam.) As the original reporter of standard-things/esm#197, I just want to express appreciation for everyone working on this. Always awesome to see OSS projects come together to support interoperability for users. Thanks y'all ❤️

@novemberborn

@novemberborn - The only other issue would be providing a way to bypass the main thread precompilation. In that case, the package sniffing I am doing wouldn't be needed.

That's tracked elsewhere, but in any case it's entirely conceivable that users may want to use @std/esm while still using AVA's transpilations.

I think we should still tighten up the pattern match, and per @jdalton's comments could clean up the .esmrc file.

I know you're generally quite busy @jamestalmage (so thanks for chiming in with this PR!). Let me know if you'd like me to land it instead.

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Dec 28, 2017

Contributor

I just want to express appreciation for everyone working on this. Always awesome to see OSS projects come together to support interoperability for users. Thanks y'all

I was pretty floored by everyone jumping in to help out. It's such a pleasant surprise to have to rein in adjustments. Double thanks to y'all ❤️

Contributor

jdalton commented Dec 28, 2017

I just want to express appreciation for everyone working on this. Always awesome to see OSS projects come together to support interoperability for users. Thanks y'all

I was pretty floored by everyone jumping in to help out. It's such a pleasant surprise to have to rein in adjustments. Double thanks to y'all ❤️

@jdalton

This comment has been minimized.

Show comment
Hide comment
@jdalton

jdalton Jan 6, 2018

Contributor

Okay, @std/esm v0.19.0 is released 🎉 (which supports that shorthand mentioned above)!

Contributor

jdalton commented Jan 6, 2018

Okay, @std/esm v0.19.0 is released 🎉 (which supports that shorthand mentioned above)!

Requested changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment