-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Document how to exclude a directory #1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "files": [ | ||
| "my-test-folder/*.js", | ||
| "!**/not-this-file.js" | ||
| "!**/exclude-this-file.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Briantmorr, you should also add an example of ignoring a directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will do!
novemberborn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping out with this @Briantmorr. Could you add the directory-ignoring example @clemtrek mentioned?
| "files": [ | ||
| "my-test-folder/*.js", | ||
| "!**/not-this-file.js" | ||
| "!**/exclude-this-file.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconded.
|
I pushed again with updated changes. Minor semantic detail, I changed the word 'folder' to directory for clarity. |
|
@Briantmorr orr, I would prefer Any thoughts on this @novemberborn |
|
👍 on These examples aren't quite right though. Once you customize
I think it might be better if the first example is |
|
Thanks for taking the time to explain @novemberborn . I greatly appreciate it! I just updated with your suggested changes! |
|
Thanks @Briantmorr! |
This pull request fixes #1750, a need for better documenting of ignore patterns . Before creating this issue user vjpr was unable to find documention on this issue with keyword searches. I added a simple explanation using the words 'ignore' and 'exclude' so that users unsure how to ignore tests will also be more likely to find my explanation in keyword searches.
I also changed not-this-file.js to exclude-this-file.js to provide a clearer example to users reading the documentation.