Properly handle empty results from test files - fixes #198 #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/babel.js
Outdated
sindresorhus
changed the title
|
I've always been in the custom of putting "fixes..." at the end, but noticed you put it at the beginning in a number of commits. But here you changed it to the end. Just want to understand the process. |
jamestalmage
force-pushed
the
fix-198
branch
from
57a72e4 to
a3308d2
Compare
|
I put fixes at the end, and if I squash merge a pull request I put the pull request issue number first. Squash merge commit for this would be something like: |
|
gotcha. Fixes are in. |
This was referenced Nov 13, 2015
sindresorhus
added a commit
that referenced
this pull request
Nov 14, 2015
Properly handle empty results from test files - fixes #198
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEE #213 FIRST
Fixes #198.