Pipe forked IO streams instead of forwarding data events.
#275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes terminal width information to, and enables ansi-color support in, the forked process. It makes the output of `time-require` much prettier when used in a fork.
Contributor
Author
There was a problem hiding this comment.
I am not sure why we forward both child output streams to stdout. I do it here simply because it is what we were doing before. Making that change will impact a lot of tests, and is a separate PR.
In my mind what we are currently doing makes the least sense of the the available options. I think we should either:
- pipe
child.stdout->process.stdout, andchild.stderr->process.stderr. - pipe both to
process.stderr. This keepsprocess.stdoutpristine and will not interfere with our TAP output.
Member
There was a problem hiding this comment.
Can you open an issue with the contents of this comment? I'm not sure to be honest.
Contributor
Author
|
@sindresorhus - this seems like a no brainer to me. What we were doing before was essentially piping to stdout. This just uses the I'm gonna merge unless you object. |
sindresorhus
added a commit
that referenced
this pull request
Nov 27, 2015
Pipe forked IO streams instead of forwarding `data` events.
Contributor
Author
|
Or that! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes terminal width information to, and enables ansi-color
support in, the forked process. It makes the output of
time-requiremuch prettier when used in a fork.