Rename test.async to test.cb #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
force-pushed
the
async-to-cb
branch
from
76665bc to
0801501
Compare
Contributor
Author
|
Nope, missed a couple string constants. Everything should be good now. |
readme.md
Outdated
Contributor
Author
There was a problem hiding this comment.
I am not seeing it.
Contributor
Author
There was a problem hiding this comment.
oh wait - yes i do.
Member
|
Looks good when typo is fixed. Just merge. |
jamestalmage
force-pushed
the
async-to-cb
branch
from
0801501 to
aa597c9
Compare
jamestalmage
force-pushed
the
async-to-cb
branch
from
aa597c9 to
7170308
Compare
jamestalmage
added a commit
that referenced
this pull request
Nov 29, 2015
Rename test.async to test.cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got everything.