Skip to content

Conversation

@ariporad
Copy link
Contributor

See #374.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this file? Looks unrelated to the intent of this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't... I have absolutely no clue why that's there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove that change? And the below file change too.

@ariporad
Copy link
Contributor Author

Ok @sindresorhus, that should be fixed now.

I have no clue why that happened... It looks like WebStorm automagically un-babel'd it.

@ariporad ariporad self-assigned this Dec 27, 2015
@jamestalmage
Copy link
Contributor

WebStorm asks you about adding a file watcher whenever it sees ES6 code. If you accidentally click yes, this can happen. I keep meaning to figure out where the setting is just to turn that off.

@ariporad
Copy link
Contributor Author

No, I get that. But it appears that WebStorm un- babel'd the code. It's
very strange.
On Sat, Dec 26, 2015 at 9:46 PM James Talmage notifications@github.com
wrote:

WebStorm asks you about adding a file watcher whenever it sees ES6 code.
If you accidentally click yes, this can happen. I keep meaning to figure
out where the setting is just to turn that off.


Reply to this email directly or view it on GitHub
#375 (comment).

@vadimdemedes
Copy link
Contributor

When I see child.js I am asking myself a question "child of what?". In my opinion, it is just as unclear as babel.js. How about forked-process.js, worker.js, test-worker.js?

@ariporad
Copy link
Contributor Author

@vdemedes: what about "subprocess.js"?

@vadimdemedes
Copy link
Contributor

@ariporad subprocess.js works too. Let's see what other guys think.

@jamestalmage
Copy link
Contributor

test-file-launcher.js

@jamestalmage
Copy link
Contributor

Also, please paint the bikeshed green.

@vadimdemedes
Copy link
Contributor

@jamestalmage a bit long, I think.

@jamestalmage
Copy link
Contributor

test-launcher.js or test-worker.js

@ariporad
Copy link
Contributor Author

@jamestalmage, @vdemedes: I still like subprocess.js or child.js.

And the bikeshed is to be blue.

@vadimdemedes
Copy link
Contributor

@jamestalmage++

@sindresorhus
Copy link
Member

👍 test-worker.js

@ariporad
Copy link
Contributor Author

Ok, I'll change it to test-worker and update the commit.

@sindresorhus sindresorhus changed the title Rename lib/babel.js to lib/child.js Rename lib/babel.js to lib/test-worker.js Dec 27, 2015
sindresorhus added a commit that referenced this pull request Dec 27, 2015
Rename lib/babel.js to lib/test-worker.js
@sindresorhus sindresorhus merged commit b0e508a into avajs:master Dec 27, 2015
@ariporad ariporad deleted the rename-babel.js branch December 27, 2015 17:54
@ariporad ariporad restored the rename-babel.js branch January 16, 2016 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants