-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Rename lib/babel.js to lib/test-worker.js #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/fixture/source-map-initial.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this file? Looks unrelated to the intent of this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't... I have absolutely no clue why that's there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove that change? And the below file change too.
38df17b to
3b32d4e
Compare
|
Ok @sindresorhus, that should be fixed now. I have no clue why that happened... It looks like WebStorm automagically un-babel'd it. |
|
WebStorm asks you about adding a file watcher whenever it sees ES6 code. If you accidentally click yes, this can happen. I keep meaning to figure out where the setting is just to turn that off. |
|
No, I get that. But it appears that WebStorm un- babel'd the code. It's
|
|
When I see |
|
@vdemedes: what about "subprocess.js"? |
|
@ariporad |
|
|
|
Also, please paint the bikeshed green. |
|
@jamestalmage a bit long, I think. |
|
|
|
@jamestalmage, @vdemedes: I still like subprocess.js or child.js. And the bikeshed is to be blue. |
|
👍 |
|
Ok, I'll change it to |
3b32d4e to
0729997
Compare
Rename lib/babel.js to lib/test-worker.js
See #374.