Skip to content

Conversation

@vadimdemedes
Copy link
Contributor

This PR fixes #372.

Mini reporter (default one) was not displaying power-assert output. Now it does (along with a stack trace):

screen shot 2015-12-27 at 11 34 43 pm

@sindresorhus
Copy link
Member

LGTM

// @ben-eb

@ben-eb
Copy link
Contributor

ben-eb commented Dec 27, 2015

👍

@jamestalmage
Copy link
Contributor

LGTM.

Though I think this highlights some deficiencies in our API.

Instead of separate errors and tests arrays, should it just be tests? A test could have a status attached (passed / failed), and all assertions with their respective results. Might be better than just standardizing errors as described in #365

@sindresorhus
Copy link
Member

Instead of separate errors and tests arrays, should it just be tests? A test could have a status attached (passed / failed), and all assertions with their respective results. Might be better than just standardizing errors as described in #365

👍 Can you open an issue?

sindresorhus added a commit that referenced this pull request Dec 27, 2015
Display power-assert output in mini reporter
@sindresorhus sindresorhus merged commit 5aeb270 into master Dec 27, 2015
@sindresorhus sindresorhus deleted the power-assert-in-mini branch December 27, 2015 23:24
@vadimdemedes
Copy link
Contributor Author

@jamestalmage we also need to store rejections and exceptions, which are not attached to any test and don't have test title, etc. So storing rejections and exceptions in tests doesn't sound right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion output regression

5 participants