Add skipped test count to builtin reporters #410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice work @sotojuan. And I agree with the yellow color since that's more "warningy", i.e. tests shouldn't really be skipped for no reason. lgtm 👍 |
Member
|
LGTM :) |
Contributor
|
LGTM:
|
Contributor
|
If mini reporter uses yellow for skipped number, we should do the same for the verbose reporter as well (it's cyan there). |
jamestalmage
added a commit
to jamestalmage/ava
that referenced
this pull request
Jan 9, 2016
PR avajs#410 missed a color change on a single log line, See: avajs#410 (comment) Using this convention will make it much easier to review PR's. No need to remember what color is used where, just ensure they don't use chalk directly, and alias the color with it's intended purpose in the colors module.
Contributor
|
@vdemedes - see #412 |
jamestalmage
added a commit
that referenced
this pull request
Jan 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #408 by adding the skipped test count to the builtin reporters, in yellow color.
Let me know if I missed anything or if another color is more appropriate.