Skip to content

Conversation

@sotojuan
Copy link
Contributor

This fixes #487 by returning an empty string instead of null when there's just one anonymous test. This also keeps the behavior of printing [anonymous] when there are more than one anonymous tests.

@sotojuan
Copy link
Contributor Author

Flaky Travis tests strike again?

@vadimdemedes
Copy link
Contributor

Yeah, something is wrong with 0.10 build, I just had an issue with it too. Restarted yours.

@sindresorhus
Copy link
Member

When there's no test title, instead of outputting an empty line, it should output nothing.

Right now it outputs the following:

❯ ava --verbose



  1 test passed


Notice that there are 3 empty lines above and only 2 below.

Instead it should only output 2 empty lines above:

❯ ava --verbose


  1 test passed


@sotojuan
Copy link
Contributor Author

sotojuan commented Feb 1, 2016

Returning an empty string does put an extra line there, and returning nothing (just return) gives an XO error. I opted to return undefined, which seems to get the job done (no extra line or extra output).

@vadimdemedes
Copy link
Contributor

@sotojuan return null did not work?

@sotojuan
Copy link
Contributor Author

null:

undefined:

'':

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output null when tests don't have a name

3 participants