Don't crash watch mode when tests files fail to transpile #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch exceptions when initially running files. Don't run any tests, just report the exception. Move test teardown into a callback for the run promise so it can be used when --match is used but there are no matches, and when exceptions occur while initially running files. Teardown causes the test promise to reject, which leads to an attempt to run the tests. Add a guard to prevent this. Fixes #622.
| // receive test count from all files and then run the tests | ||
| var unreportedFiles = self.fileCount; | ||
|
|
||
| var tests = new Array(self.fileCount); |
Contributor
There was a problem hiding this comment.
Could you explain why is array of N (self.fileCount) null elements needed?
Contributor
There was a problem hiding this comment.
It gets filled with promises for run results here
Member
Author
There was a problem hiding this comment.
Yea. I'm just preallocating it to the right size.
Member
|
LGTM |
Contributor
|
👍 |
sindresorhus
added a commit
that referenced
this pull request
Mar 10, 2016
Don't crash watch mode when tests files fail to transpile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #622.
Catch exceptions when initially running files. Don't run any tests, just report the exception.
Move test teardown into a callback for the run promise so it can be used when
--matchis used but there are no matches, and when exceptions occur while initially running files.Teardown causes the test promise to reject, which leads to an attempt to run the tests. Add a guard to prevent this.