Skip to content

Conversation

nfcampos
Copy link
Contributor

on master running ava blah assuming blah matches no files will fail like this
screen shot 2016-05-17 at 11 02 14

instead of like this, as it should
screen shot 2016-05-17 at 11 03 00

This happens because when no files are found Api.prototype.run is returning an empty array instead of runStatus. So it then fails in the reporter, which in its finish method expects its argument to be an instance of runStatus instead of an empty array

@nfcampos nfcampos changed the title api should return runStatus even when no files are found api#run should return runStatus even when no files are found May 17, 2016
@jamestalmage
Copy link
Contributor

Good catch! Can you add a test to test/cli.js that protects against future regressions?

@nfcampos
Copy link
Contributor Author

sure

@nfcampos
Copy link
Contributor Author

I've rebased and added the test :)

@jamestalmage
Copy link
Contributor

LGTM

@novemberborn novemberborn merged commit ee76aa9 into avajs:master May 18, 2016
@novemberborn
Copy link
Member

Thanks @nfcampos!

@nfcampos nfcampos deleted the patch-1 branch May 18, 2016 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants