ParsingFailureAction and related API changes #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PullResult instead of Option for RabbitMQPullConsumer ConversionException to api module
augi
requested changes
May 22, 2018
README.md
Outdated
|
|
||
| #### Consumer parsing failure | ||
|
|
||
| It may happen the delivery is not parsable as your `MyClass`. It won't be passed into the consumer and `ParsingFailureAction` will be used |
There was a problem hiding this comment.
I would prefer to have something like PullResult as input to regular consumer (created via newConsumer). So use a sealed trait instead of plain Delivery. I believe the code would be more concise.
README.md
Outdated
|
|
||
| #### Pull-Consumer parsing failure | ||
|
|
||
| It may happen the delivery is not parsable as your `MyClass`. `ParsingFailureAction` will be used for handling such message and you will get |
There was a problem hiding this comment.
I would prefer to remove this feature - it's not IMHO required because you can achieve the same behavior just by processing the PullResult.MalformedContent when calling pull. You have to handle this case anyway...
removed ParsingFailureAction PullResult removed MalformedContent
|
Updated. The |
augi
approved these changes
May 24, 2018
Migration-5-6.md
Outdated
| 1. The API now uses type-conversions - provide type and related converter when creating producer/consumer. | ||
| See [related section](README.md#providing-converters-for-producer/consumer) in docs. | ||
| 1. The `Delivery` is now generic - e.g. `Delivery[Bytes]` (depends on type-conversion). | ||
| 1. The `Delivery` is now sealed trait - there are `Delivery.Ok[A]` (e.g. `Delivery[Bytes]` ,depends on type-conversion) and `Delivery.MalformedContent`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PullResult instead of Option for RabbitMQPullConsumer
ConversionException to api module
Sorry for so big PR however it's cause mainly by moving
ConversionExceptioninto another package (and module).