Skip to content

Conversation

@sabinbaniya
Copy link
Contributor

@sabinbaniya sabinbaniya commented Feb 11, 2022

Fixes Issue

#22

Changes proposed

Added Get Static Path snippet for Next.js for both TypeScript and JavaScript

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@0xMukesh 0xMukesh requested a review from avneesh0612 February 11, 2022 14:00
@anuraglol anuraglol self-requested a review February 11, 2022 14:02
Copy link
Owner

@avneesh0612 avneesh0612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, can you add these in the readme? :)

@anuraglol
Copy link
Collaborator

anuraglol commented Feb 11, 2022

also use conventional commit messages :P

@sabinbaniya
Copy link
Contributor Author

Okay I will update the changes on the readme as well. With the conventional commit messages ;)

@sabinbaniya sabinbaniya changed the title Next js get static path add feat: added next js get static path Feb 11, 2022
Copy link
Collaborator

@0xMukesh 0xMukesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@anuraglol
Copy link
Collaborator

LGTM! 🚀

Copy link
Owner

@avneesh0612 avneesh0612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing! :)

@avneesh0612 avneesh0612 merged commit d9c76e3 into avneesh0612:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants