Automate Windows builds #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP. Debug Windows Release workflow. WIP. Debug Windows Release workflow. WIP. Debug Windows Release workflow
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR automates the creation of Windows release builds for the crc_fast PHP extension. When a version tag is pushed and tests pass, the workflow automatically builds Windows DLLs for multiple PHP versions and architectures, then creates a draft GitHub release with these artifacts attached. This eliminates the need for manual Windows builds and ensures consistent, reproducible releases.
- Updates the test workflow to use pre-built releases of the crc-fast-rust library instead of building from source
- Adds a new Windows Release workflow that triggers on successful test runs for version tags
- Implements multi-architecture (x64, arm64) and multi-PHP version (8.1-8.4) build matrix using php-windows-builder
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
.kiro/specs/windows-automated-releases/tasks.md |
Implementation plan tracking completed tasks for the Windows release automation feature |
.kiro/specs/windows-automated-releases/requirements.md |
Requirements documentation outlining the acceptance criteria for the automated release system |
.kiro/specs/windows-automated-releases/design.md |
Detailed design document describing the architecture, components, and implementation details of the release workflow |
.github/workflows/windows-release.yaml |
New workflow file implementing the Windows release automation with build matrix, library download, and draft release creation |
.github/workflows/tests.yaml |
Updated test workflow to download pre-built crc-fast library releases instead of building from source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
We'd like to product automated release builds for Windows and attach them to immutable GitHub releases.
The Solution
Add a Windows Release GitHub workflow that builds Windows releases (DLLs), opens a Draft Release, and attaches the DLLs to the release.
Changes
Planned version bump
PATCH