feat: differentiate between timestamp formats in json unmarshaller #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphkim
changed the title
TrekSoft
reviewed
Jul 17, 2020
aws-android-sdk-core/src/main/java/com/amazonaws/transform/SimpleTypeJsonUnmarshallers.java
Show resolved
Hide resolved
TrekSoft
approved these changes
Jul 17, 2020
Contributor
TrekSoft
left a comment
TrekSoft
left a comment
There was a problem hiding this comment.
Approved pending minor formatting comment.
| Number number = NumberFormat.getInstance(new Locale("en")).parse(dateString); | ||
| return new Date(number.longValue() * DATE_MULTIPLIER); | ||
| } catch (ParseException e) { | ||
| switch (format) { |
Contributor
There was a problem hiding this comment.
Ahh okay nice. This is a clean solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add
TimestampFormatenum to be passed to the unmarshaller to more accurately unmarshall date strings.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.