Skip to content

Conversation

@AndreasBoehm
Copy link
Contributor

@AndreasBoehm AndreasBoehm commented Nov 22, 2021

Issue #, if available:
#2660
#2614

Description of changes:

  • Allows the default browser to be launched in case no browser that supports Custom Tabs has been found. Previously the login would abort because Custom Tabs was a hard requirement for web-ui sign-in.
  • CustomTabs will now determine the preferred Custom Tabs Service to allow us to use Custom Tabs of any browser even if the default browser does not support that feature.
  • pre-warming of Custom-Tabs adjusted to use the preferred Custom Tabs Service
  • Update androidx.browser:browser to 1.4.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AndreasBoehm
Copy link
Contributor Author

Hi @raphkim, could you please take a look at this pull-request? Thank you.

@AndreasBoehm
Copy link
Contributor Author

Hi @sktimalsina, @eeatonaws, @poojamat,

I don't want to annoy you but could you please help me to get this merged?
This is blocking us from releasing a new feature to our users.

Best regards,
Andi

@div5yesh
Copy link
Contributor

div5yesh commented Dec 7, 2021

Thank you for contributing. We are reviewing and testing this PR.

@Lettly
Copy link

Lettly commented Dec 21, 2021

Sorry for bothering, but there is any update on this pull request @div5yesh? At this moment we are telling our user to switch to chrome, but it isn't a long-term solution.

@sktimalsina sktimalsina requested review from a team and sktimalsina December 27, 2021 18:20
@sktimalsina sktimalsina changed the title Fix social-sign-in in web-ui when default browser does not support custom-tabs fix: social-sign-in in web-ui when default browser does not support custom-tabs Dec 27, 2021
@sktimalsina sktimalsina merged commit 3ad6015 into aws-amplify:main Dec 28, 2021
@AndreasBoehm AndreasBoehm deleted the AndreasBoehm/fix/no-browser-found branch December 28, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to start sign in with social web UI when default browser does not support Custom Chrome Tab

5 participants