Skip to content

update with the added CLI interactions category #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mlabieniec merged 3 commits into from
Oct 14, 2018
Merged

update with the added CLI interactions category #14

mlabieniec merged 3 commits into from
Oct 14, 2018

Conversation

@UnleashedMind
Copy link
Contributor

@UnleashedMind UnleashedMind commented Oct 11, 2018

…support

undefobj
undefobj reviewed Oct 11, 2018
View reviewed changes
Copy link
Contributor

@undefobj undefobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug at the top:

Ensure you have [installed and configured the Amplify CLI and library]({%if jekyll.environment == 'production'%}{{site.amplify.docs_baseurl}}{%endif%}/media/quick_start). {: .callout .callout--info}

undefobj
undefobj reviewed Oct 11, 2018
View reviewed changes
Copy link
Contributor

@undefobj undefobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS Amplify implements Amazon Lex as the default chatbots service. Amazon Lex supports creating conversational bots with the by the same deep learning technologies that power Amazon Alexa.

^^^^ remove the "by" in the "with the by the"

undefobj
undefobj reviewed Oct 11, 2018
View reviewed changes
js/interactions.md

You are allowed to run the `amplify add interactions` command multiple times to add multiple chatbots into your project.

{The Interactions category utilizes the Authentication category behind the scenes to authorize your app to send analytics events.}
Copy link
Contributor

@undefobj undefobj Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is buggy here - "{The Interactions category utilizes the Authentication category behind the scenes to authorize your app to send analytics events.} {: .callout .callout--info}"

undefobj
undefobj reviewed Oct 11, 2018
View reviewed changes
js/interactions.md

Amplify.configure(aws_exports);
```

Copy link
Contributor

@undefobj undefobj Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link to jump straight to the "Working with the Interactions API" section? Like "Click HERE for usage in your app"

undefobj
undefobj reviewed Oct 11, 2018
View reviewed changes
js/interactions.md Outdated

You can create Amazon Lex chatbox in Amazon Lex console. To create your bot, follow the steps shown in [Amazon Lex Developer Guide](https://docs.aws.amazon.com/lex/latest/dg/getting-started.html).

![Interactions]({%if jekyll.environment == 'production'%}{{site.amplify.docs_baseurl}}{%endif%}/media/images/interactions_lex_console_edit_bot.jpg){: class="screencap" style="max-height:600px;"}
Copy link
Contributor

@undefobj undefobj Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another bug - ![Interactions]({%if jekyll.environment == 'production'%}{{site.amplify.docs_baseurl}}{%endif%}/media/images/interactions_lex_console_edit_bot.jpg){: class="screencap" style="max-height:600px;"

undefobj
undefobj suggested changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@undefobj undefobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good structure, mostly just build bugs that need to be resolved which are making it into the markup. I commented on a few of them but also at the bottom under "Using with Angular and Ionic" and "API Reference". Finally could you rename the "Working with the API" section to "Working with the Interactions API".

@mlabieniec
Copy link
Contributor

mlabieniec commented Oct 11, 2018

Ensure the links are correct, they have changed in the new repo. For example There is no /media/quick_start it is now /js/start

@UnleashedMind
Copy link
Contributor Author

UnleashedMind commented Oct 11, 2018

I made the changes that Richard requested.
I checked the "build errors", I think those are jekyll build directives, it points to the production hosting url, and I just checked, they are actually correct.

@mlabieniec mlabieniec merged commit ccde756 into aws-amplify:master Oct 14, 2018
undefobj added a commit that referenced this pull request Dec 3, 2019
@undefobj
Merge pull request #14 from undefobj/intensify
65bf135 
Initial commit
mlabieniec added a commit that referenced this pull request Feb 13, 2021
@mlabieniec
Fix type error on register
4bb1f4b 
```
E/flutter (30435): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, String>'
E/flutter (30435): #0      new CognitoSignUpOptions (package:amplify_auth_cognito/src/CognitoSignUp/CognitoSignUpOptions.dart:20:87)
E/flutter (30435): #1      SignUpState._signUp (package:AwsAmplifySample/components/signUp.dart:29:20)
E/flutter (30435): #2      SignUpState.build.<anonymous closure> (package:AwsAmplifySample/components/signUp.dart:190:35)
E/flutter (30435): #3      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:993:19)
E/flutter (30435): #4      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:1111:38)
E/flutter (30435): #5      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:183:24)
E/flutter (30435): #6      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:598:11)
E/flutter (30435): #7      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:287:5)
E/flutter (30435): #8      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestures/tap.dart:259:7)
E/flutter (30435): #9      GestureArenaManager.sweep (package:flutter/src/gestures/arena.dart:157:27)
E/flutter (30435): #10     GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:362:20)
E/flutter (30435): #11     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:338:22)
E/flutter (30435): #12     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:267:11)
E/flutter (30435): #13     GestureBinding._handlePointerEvent (package:flutter/src/gestures/binding.dart:295:7)
E/flutter (30435): #14     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:240:7)
E/flutter (30435): #15     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:213:7)
E/flutter (30435): #16     _rootRunUnary (dart:async/zone.dart:1206:13)
E/flutter (30435): #17     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
E/flutter (30435): #18     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7)
E/flutter (30435): #19     _invoke1 (dart:ui/hooks.dart:265:10)
E/flutter (30435): #20     _dispatchPointerDataPacket (dart:ui/hooks.dart:174:5)
E/flutter (30435): 
```

If `dynamic` is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@undefobj undefobj undefobj requested changes

@mlabieniec mlabieniec mlabieniec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UnleashedMind @mlabieniec @undefobj