Skip to content

Conversation

@itamm15
Copy link
Contributor

@itamm15 itamm15 commented Nov 21, 2025

closes: #220

Comment on lines 122 to 126
def create(access_key_id, secret_access_key, region) do
%AWS.Client{
access_key_id: access_key_id,
secret_access_key: secret_access_key,
region: region
}
create(access_key_id, secret_access_key, nil, region, nil)
end

def create(access_key_id, secret_access_key, token, region) do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the previous API, so no breaking changes are made.

@onno-vos-dev
Copy link
Member

Do keep in mind that Localstack is far from perfect. In particular when it comes to signatures it may pass while in reality it is severely broken... 😢 So just be aware that your mileage in terms of testing with Localstack may vary from actual true AWS 👍

@onno-vos-dev onno-vos-dev merged commit 630837c into aws-beam:master Nov 21, 2025
2 checks passed
@onno-vos-dev
Copy link
Member

Will create a release in a few minutes and circle back 👍

@onno-vos-dev
Copy link
Member

@itamm15 1.0.10 released

@itamm15
Copy link
Contributor Author

itamm15 commented Nov 21, 2025

Thank you very much, @onno-vos-dev! I do really appreciate the quick feedback ❤️
I was not aware of that - will bear that fact in my mind!
Wish you the best day! 😄

@itamm15
Copy link
Contributor Author

itamm15 commented Nov 21, 2025

Oh, and one more thing - would you like me to enhance the docs? (and update them accordingly with the endpoint env change?)

@onno-vos-dev
Copy link
Member

Feel free to follow up with such a PR 👍 I'll merge it but won't do the whole release train dance for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make endpoint config env

2 participants