-
Notifications
You must be signed in to change notification settings - Fork 135
chore: add support for endpoint env #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for endpoint env #221
Conversation
| def create(access_key_id, secret_access_key, region) do | ||
| %AWS.Client{ | ||
| access_key_id: access_key_id, | ||
| secret_access_key: secret_access_key, | ||
| region: region | ||
| } | ||
| create(access_key_id, secret_access_key, nil, region, nil) | ||
| end | ||
|
|
||
| def create(access_key_id, secret_access_key, token, region) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the previous API, so no breaking changes are made.
|
Do keep in mind that Localstack is far from perfect. In particular when it comes to signatures it may pass while in reality it is severely broken... 😢 So just be aware that your mileage in terms of testing with Localstack may vary from actual true AWS 👍 |
|
Will create a release in a few minutes and circle back 👍 |
|
Thank you very much, @onno-vos-dev! I do really appreciate the quick feedback ❤️ |
|
Oh, and one more thing - would you like me to enhance the docs? (and update them accordingly with the |
|
Feel free to follow up with such a PR 👍 I'll merge it but won't do the whole release train dance for it. |
closes: #220