consolidating on PSEUDOPARAMS from cfnlint.helpers#1172
Merged
kddejong merged 2 commits intoaws-cloudformation:masterfrom Oct 29, 2019
PatMyron:master
Merged
consolidating on PSEUDOPARAMS from cfnlint.helpers#1172kddejong merged 2 commits intoaws-cloudformation:masterfrom PatMyron:master
kddejong merged 2 commits intoaws-cloudformation:masterfrom
PatMyron:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
- Coverage 87.76% 87.75% -0.01%
==========================================
Files 135 135
Lines 8007 8006 -1
Branches 1970 1970
==========================================
- Hits 7027 7026 -1
Misses 581 581
Partials 399 399
Continue to review full report at Codecov.
|
Contributor
|
Digging into these failures |
kddejong
requested changes
Oct 27, 2019
kddejong
approved these changes
Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/pseudo-parameter-reference.html
AWS::NoValuewas missing fromhttps://github.com/aws-cloudformation/cfn-python-lint/blob/c73209fe2ba24c511f040a6eecb6da878b2d5ac6/src/cfnlint/rules/functions/Sub.py#L104-L112
Not sure if that was intentional or not