Skip to content

allow for !Condition in Conditions#1246

Merged
kddejong merged 2 commits intoaws-cloudformation:masterfrom
jonathanmorley:top-level-conditions
Dec 5, 2019
Merged

allow for !Condition in Conditions#1246
kddejong merged 2 commits intoaws-cloudformation:masterfrom
jonathanmorley:top-level-conditions

Conversation

@jonathanmorley
Copy link
Copy Markdown
Contributor

Issue: #1245

Description of changes: Allow top-level !Conditions within the Conditions block

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1246 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1246   +/-   ##
======================================
  Coverage    87.7%   87.7%           
======================================
  Files         136     136           
  Lines        8079    8079           
  Branches     1986    1986           
======================================
  Hits         7086    7086           
  Misses        588     588           
  Partials      405     405
Impacted Files Coverage Δ
src/cfnlint/rules/conditions/Configuration.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c73f48...4a322c4. Read the comment docs.

@kddejong kddejong merged commit cc132c0 into aws-cloudformation:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants