Skip to content

Conversation

@ammokhov
Copy link
Contributor

@ammokhov ammokhov commented Aug 7, 2021

Issue #, if available:

Description of changes:

#162 merging external contribution with some small changes.

Passed local testing with sample resource.
local build:

$ pre-commit run --all-files
isort....................................................................Passed
black....................................................................Passed
Check for case conflicts.................................................Passed
Fix End of Files.........................................................Passed
Mixed line ending........................................................Passed
Trim Trailing Whitespace.................................................Passed
Flake8...................................................................Passed
Pretty format JSON.......................................................Passed
Check for merge conflicts................................................Passed
Check Yaml...............................................................Passed
Check blanket noqa.......................................................Passed
check for not-real mock methods..........................................Passed
use logger.warning(......................................................Passed
bandit...................................................................Passed
mypy.....................................................................Passed
pylint-local.............................................................Passed
pytest-local.............................................................Passed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammokhov ammokhov changed the title Type annotation branch Added Type[BaseModel] Annotation to TypeConfiguration Aug 7, 2021
@ammokhov ammokhov self-assigned this Aug 7, 2021
@ammokhov ammokhov added the good first issue Good for newcomers label Aug 7, 2021
@ammokhov ammokhov force-pushed the type-annotation-branch branch from 8d0721b to f51f1b4 Compare August 7, 2021 05:07
@ammokhov ammokhov merged commit 9d494c9 into aws-cloudformation:master Aug 10, 2021
@ammokhov ammokhov deleted the type-annotation-branch branch August 10, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants