Skip to content

Conversation

@eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented May 2, 2020

Issue #, if available:

Description of changes:

While trying to access the instance with this in an event handler method, the following error was being thrown:

TypeError: Cannot read property 'typeName' of undefined

The change here fix the issue by binding the instance to the method.

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #7 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   94.24%   94.26%   +0.02%     
==========================================
  Files          13       13              
  Lines         834      837       +3     
  Branches      123      124       +1     
==========================================
+ Hits          786      789       +3     
  Misses         48       48              
Flag Coverage Δ
#unittests 94.26% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/resource.ts 96.41% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a89f4...97dd3dc. Read the comment docs.

@eduardomourar eduardomourar merged commit b35a0f6 into master May 2, 2020
@eduardomourar eduardomourar deleted the feature/bind-event-handler branch May 2, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant