Skip to content

Conversation

@konoui
Copy link
Contributor

@konoui konoui commented Nov 23, 2022

address #9 , #10

I addressed issues at the same time since a fix of #10 is related to #9 .
If separating PR is required, please let me know.

Descriptions

  • chage test directory to tests to match Makefile and README.md
  • check a condition for each resource in the same workload
  • add checking a condition of daemonset
  • support ReplicaSet to avoid panic
    • there are several ways to avoid it e.g.) skip replicaset check, fallback to the pod handling, but I think adding it looks simple and useful.

@konoui konoui force-pushed the fix-exit-code-and-replicaset-panic branch from 43d34e2 to d9f7070 Compare November 23, 2022 11:57
@rothgar
Copy link
Contributor

rothgar commented Nov 23, 2022

Thanks so much for the PR and open issues. I'll test this next week.

@rothgar rothgar merged commit b083161 into aws-containers:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants