Bootstrap Bedrock Controller #1
Conversation
ack-prow
bot
added
the
do-not-merge/invalid-owners-file
GOVERNANCE.md
Outdated
|
|
||
| ## Communication | ||
|
|
||
| The primary mechanism for communication will be via the `#provider-aws` channel on the Kubernetes Slack community. |
There was a problem hiding this comment.
Is provider-aws still the main slack channel? From what I can tell that a more general slack channel for AWS/Kubernetes. It seems like aws-controllers-k8s should at least be mentioned.
There was a problem hiding this comment.
This file needs to be populated. Is a copy of code the community repo's ATTRIBUTION sufficient?
There was a problem hiding this comment.
generally, yes. Or you can generate it https://github.com/awslabs/attribution-gen
OWNERS
Outdated
| approvers: | ||
| - core-ack-team | ||
| - service-team |
There was a problem hiding this comment.
Need to remove service-team.
OWNERS_ALIASES
Outdated
| - a-hilaly | ||
| - RedbackThomson | ||
| - jljaco |
There was a problem hiding this comment.
Do these default values need to be changed?
There was a problem hiding this comment.
|
|
||
| TODO: Fill this README out! | ||
| This repository contains source code for the AWS Controllers for Kubernetes | ||
| (ACK) service controller for . |
There was a problem hiding this comment.
Complete this sentence.
There was a problem hiding this comment.
this information is loaded from metadata.yaml
There was a problem hiding this comment.
Do we need to manually trigger something to update this info based on metadata.yaml?
There was a problem hiding this comment.
that's a good question, i'm sure how it's automated.. there is a missing piece or perhaps a chicken/egg problem?
There was a problem hiding this comment.
Would it be running controller-bootstrap update? Looking at the Glue Controller the trigger can be missed.
go.mod
Outdated
| @@ -0,0 +1,14 @@ | |||
| module github.com/aws-controllers-k8s/bedrock-controller | |||
|
|
|||
| go 1.19 | |||
There was a problem hiding this comment.
Go version should be update
| @@ -0,0 +1,8 @@ | |||
| service: | |||
| @@ -0,0 +1,40 @@ | |||
| # This configuration is a placeholder. Replace any values with relevant values for your | |||
There was a problem hiding this comment.
Update placeholder values.
There was a problem hiding this comment.
Where do we usually source this description from? Are there marketing rules/materials we need to be consistent with?
There was a problem hiding this comment.
Not that i'm aware off, @acornett21 do you have any guidance for us here?
There was a problem hiding this comment.
This info usually comes form the AWS docs site, most projects are at /developer-resources but some projects are not. Example for S3
https://aws.amazon.com/s3/developer-resources/
then the Developer Guide
https://docs.aws.amazon.com/AmazonS3/latest/userguide//Welcome.html
ack-prow
bot
added
the
do-not-merge/work-in-progress
ack-prow
bot
removed
the
do-not-merge/invalid-owners-file
ack-prow
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: a-hilaly, knottnt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.