Support inference profile #6
Conversation
Add .vscode
- Ignore all resources except for InferenceProfile - Add hooks for setting InferenceProfileIdentifier with ARN - Set non-tag fields as immutable
- Add custom update method to update tags if a delta is detected - Add hooks for read and updating tags
- Update generator.yaml to add InferenceProfileID from GetInferenceProfile operation
ack-prow
bot
added
the
do-not-merge/work-in-progress
|
/test all |
|
/retest |
ack-prow
bot
removed
the
do-not-merge/work-in-progress
|
@knottnt: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| // custom_update handles updates for inference profiles. Since inference profiles | ||
| // are immutable resources, only tag updates are supported. | ||
| func (rm *resourceManager) custom_update( |
There was a problem hiding this comment.
| func (rm *resourceManager) custom_update( | |
| func (rm *resourceManager) customUpdate( |
| return nil, err | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we also support the other update paths or is this an immutable resource?
There was a problem hiding this comment.
No, inference profile doesn't currently have an update operation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, knottnt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &resource{ko}, nil |
There was a problem hiding this comment.
@knottnt looks like we need a requeue when status is CREATING?
There was a problem hiding this comment.
Ahh will add a synced when config to generator.yaml
There was a problem hiding this comment.
please move to the outer folder
There was a problem hiding this comment.
By outer folder do you mean /pkg/tags/sync.go?
2 participants
Issue #, if available: 2581
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.