Skip to content

Fix resource synced status #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

Fix resource synced status #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c9f92d
Move tags folder to /pkg/tags
knottnt Oct 15, 2025
c2ff161
Update generator.yaml
knottnt Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-10-10T17:21:27Z"
build_date: "2025-10-15T17:26:29Z"
build_hash: eaabefb6bd7b2be8a1baf4478f22b3310e6921c8
go_version: go1.25.0
version: v0.52.0-6-geaabefb
api_directory_checksum: c2a05f6479bd52a75cd0edad0268006c9c330238
api_version: v1alpha1
aws_sdk_go_version: v1.39.0
generator_config_info:
file_checksum: d05d6b6dae697b39793019251b54bcf9766f0238
file_checksum: 52a529428a3927a25df922fa900a75630016a7c7
original_file_name: generator.yaml
last_modification:
reason: API generation
8 changes: 7 additions & 1 deletion apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ resources:
InferenceProfile:
is_arn_primary_key: true
update_operation:
custom_method_name: custom_update
custom_method_name: customUpdate

fields:
Description:
Expand All @@ -56,4 +56,10 @@ resources:
sdk_delete_post_build_request:
template_path: hooks/inference_profile/sdk_delete_post_build_request.go.tpl

synced:
when:
- path: Status.Status
in:
- ACTIVE


8 changes: 7 additions & 1 deletion generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ resources:
InferenceProfile:
is_arn_primary_key: true
update_operation:
custom_method_name: custom_update
custom_method_name: customUpdate

fields:
Description:
Expand All @@ -56,4 +56,10 @@ resources:
sdk_delete_post_build_request:
template_path: hooks/inference_profile/sdk_delete_post_build_request.go.tpl

synced:
when:
- path: Status.Status
in:
- ACTIVE


6 changes: 3 additions & 3 deletions pkg/resource/inference_profile/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"context"

svcapitypes "github.com/aws-controllers-k8s/bedrock-controller/apis/v1alpha1"
"github.com/aws-controllers-k8s/bedrock-controller/pkg/resource/tags"
"github.com/aws-controllers-k8s/bedrock-controller/pkg/tags"
ackcompare "github.com/aws-controllers-k8s/runtime/pkg/compare"
)

Expand Down Expand Up @@ -51,9 +51,9 @@ func (rm *resourceManager) customCheckRequired(r *resource) bool {
return r.ko.Status.ACKResourceMetadata == nil || r.ko.Status.ACKResourceMetadata.ARN == nil
}

// custom_update handles updates for inference profiles. Since inference profiles
// customUpdate handles updates for inference profiles. Since inference profiles
// are immutable resources, only tag updates are supported.
func (rm *resourceManager) custom_update(
func (rm *resourceManager) customUpdate(
ctx context.Context,
desired *resource,
latest *resource,
Expand Down
8 changes: 8 additions & 0 deletions pkg/resource/inference_profile/manager.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/resource/inference_profile/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 pkg/resource/tags/sync.go → pkg/tags/sync.go
View file
Open in desktop
File renamed without changes.
0 pkg/resource/tags/sync_test.go → pkg/tags/sync_test.go
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions test/e2e/tests/test_inference_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def test_create_delete_inference_profile(self, simple_inference_profile, bedrock
assert inference_profile_arn is not None
assert cr["spec"]["description"] == TEST_DESCRIPTION
assert cr["spec"]["modelSource"]["copyFrom"] == TEST_MODEL_ID
assert cr["status"]["status"] == "ACTIVE"

expected_tags = [
{"key": TAG_KEY_1, "value": TAG_VALUE_1},
Expand Down