Skip to content

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented May 12, 2025

Description of changes:

  • Use controller-bootstrap to initialize bedrock-agent controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knottnt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knottnt knottnt requested review from a-hilaly and rushmash91 May 12, 2025 18:05
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @knottnt 👍
can you add this to test-infra jobs-config as well?

metadata.yaml Outdated
Comment on lines 1 to 5
service:
full_name:
short_name:
link:
documentation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update these?

Add name and links.
@knottnt knottnt requested a review from michaelhtm May 12, 2025 22:22
@knottnt
Copy link
Contributor Author

knottnt commented May 12, 2025

Thanks @knottnt 👍 can you add this to test-infra jobs-config as well?

@michaelhtm Added in this PR.

@a-hilaly
Copy link
Member

/test all

full_name: Amazon Bedrock
short_name: Bedrock
link: https://aws.amazon.com/bedrock/
documentation: https://docs.aws.amazon.com/bedrock/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For controllers that are split-up should we point this at the API Reference specific to the controller's resources? For example this could be pointed at this link.

@ack-prow
Copy link

ack-prow bot commented May 12, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
bedrockagent-unit-test f63c481 link true /test bedrockagent-unit-test
bedrockagent-verify-attribution f63c481 link false /test bedrockagent-verify-attribution
bedrockagent-recommended-policy-test f63c481 link true /test bedrockagent-recommended-policy-test
bedrockagent-release-test f63c481 link true /test bedrockagent-release-test
bedrockagent-kind-e2e f63c481 link true /test bedrockagent-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly a-hilaly merged commit 562017b into aws-controllers-k8s:main May 13, 2025
1 of 7 checks passed
@knottnt
Copy link
Contributor Author

knottnt commented May 13, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants