-
Notifications
You must be signed in to change notification settings - Fork 4
Bootstrap Controller #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add sdk name
add service description
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knottnt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @knottnt 👍
can you add this to test-infra jobs-config as well?
metadata.yaml
Outdated
| service: | ||
| full_name: | ||
| short_name: | ||
| link: | ||
| documentation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we update these?
Add name and links.
@michaelhtm Added in this PR. |
|
/test all |
| full_name: Amazon Bedrock | ||
| short_name: Bedrock | ||
| link: https://aws.amazon.com/bedrock/ | ||
| documentation: https://docs.aws.amazon.com/bedrock/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For controllers that are split-up should we point this at the API Reference specific to the controller's resources? For example this could be pointed at this link.
|
@knottnt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.