Skip to content

Conversation

@knottnt
Copy link
Contributor

@knottnt knottnt commented May 13, 2025

Issue #, if available: 2117

Description of changes:

  • Generate Helm files
  • Generate basic controller Go code
  • Generate deployment files for controller
  • Generated changes to project files

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

knottnt added 3 commits May 13, 2025 10:03
- Generate Helm files
- Generate basic controller Go code
- Generate deployment files for controller
- Generated changes to project files
@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 May 13, 2025 17:18
@ack-prow ack-prow bot added the approved label May 13, 2025
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like recommended IAM policy is the only thing missing..
https://github.com/aws-controllers-k8s/iam-controller/tree/main/config/iam

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added AmazonBedrockFullAccess as the recommended policy arn for now.

@ack-prow
Copy link

ack-prow bot commented May 13, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
bedrockagent-verify-attribution 43f9892 link false /test bedrockagent-verify-attribution
bedrockagent-kind-e2e 43f9892 link true /test bedrockagent-kind-e2e
bedrockagent-release-test 43f9892 link true /test bedrockagent-release-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ack-prow
Copy link

ack-prow bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,knottnt,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm michaelhtm merged commit ff44855 into aws-controllers-k8s:main May 13, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants