-
Notifications
You must be signed in to change notification settings - Fork 11
Update to ACK runtime v0.56.0, code-generator v0.56.0
#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 days ago
To address the issue, add a permissions block to the workflow at the root level (before jobs:) in .github/workflows/postsubmit.yaml. This block should assign the least privilege—ideally, contents: read unless you are certain that further permissions (such as issues: write or pull-requests: write) are required by downstream jobs. Since this workflow delegates its job using uses:, and there's no indication of needing elevated permissions, set the minimal starting point recommended by CodeQL: permissions: contents: read. Insert this block immediately after the name: or after the on: block for clarity.
-
Copy modified lines R3-R5
| @@ -1,5 +1,8 @@ | ||
| name: Hydrate Go Proxy | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.2.2tov1.3.0Once this PR is merged, release
v1.3.0will be automatically created forcloudfront-controllerPlease close this PR, if you do not want the new patch release for
cloudfront-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.