Add support for nested fields when using Set config #627
Conversation
- Check for SetConfigs for child fields in SetSDKForStruct - Add testdata for firehose service - Add unit test to verify nested set behavior. - Cleanup leftover print statement
|
/retest |
|
@knottnt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| ` | ||
| actual := code.SetSDK(crd.Config(), crd, model.OpTypeCreate, "r.ko", "res", 1) | ||
| fmt.Print(actual) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-prow
bot
merged commit 3756200
into
aws-controllers-k8s:main
2 participants
Issue #, if available:
Description of changes:
Add support for applying Set config's
-toto child fields of Struct field.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.