Skip to content

feat: easy localstack integration #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: easy localstack integration #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions templates/helm/templates/deployment.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ spec:
- "$(AWS_REGION)"
- --aws-endpoint-url
- "$(AWS_ENDPOINT_URL)"
{{- if .Values.aws.identity_endpoint_url }}
- --aws-identity-endpoint-url
- "$(AWS_IDENTITY_ENDPOINT_URL)"
{{- end }}
{{- if .Values.aws.allow_unsafe_aws_endpoint_urls }}
- --allow-unsafe-aws-endpoint-urls
{{- end }}
Comment on lines +54 to +60
Copy link
Member

@a-hilaly a-hilaly Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @aleslash.

These need to be a template of a template like:

{{ "{{- if .Values.log.enable_development_logging }}" }}
        - --enable-development-logging
{{ "{{- end }}" }}

can you please address this?

{{ "{{- if .Values.log.enable_development_logging }}" }}
- --enable-development-logging
{{ "{{- end }}" }}
Expand Down Expand Up @@ -109,6 +116,8 @@ spec:
value: {{ "{{ .Values.aws.region }}" }}
- name: AWS_ENDPOINT_URL
value: {{ "{{ .Values.aws.endpoint_url | quote }}" }}
- name: AWS_IDENTITY_ENDPOINT_URL
value: {{ .Values.aws.identity_endpoint_url | quote }}
- name: ACK_WATCH_NAMESPACE
value: {{ IncludeTemplate "watch-namespace" }}
- name: ACK_WATCH_SELECTORS
Expand Down
9 changes: 8 additions & 1 deletion templates/helm/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,16 @@
"region": {
"type": "string"
},
"endpoint": {
"endpoint_url": {
"type": "string"
},
"identity_endpoint_url": {
"type": "string"
},
"allow_unsafe_aws_endpoint_urls": {
"type": "boolean",
"default": false
},
"credentials": {
"description": "AWS credentials information",
"properties": {
Expand Down
2 changes: 2 additions & 0 deletions templates/helm/values.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ aws:
# If specified, use the AWS region for AWS API calls
region: ""
endpoint_url: ""
identity_endpoint_url: ""
allow_unsafe_aws_endpoint_urls: false
credentials:
# If specified, Secret with shared credentials file to use.
secretName: ""
Expand Down