Skip to content

Conversation

@michaelhtm
Copy link
Member

Issue #2673

Description of changes:
This change ensures the system tags ignored are
passed by runtime, instead of hard coding a specific value.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This change ensures the system tags ignored are passed by runtime,
instead of hardcoding a specific value.
@ack-prow ack-prow bot requested review from knottnt and rushmash91 November 23, 2025 05:44
@ack-prow ack-prow bot added the approved label Nov 23, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm michaelhtm force-pushed the fix/ignoretagspassedonstart branch from 0e7a3aa to dbadfc5 Compare November 23, 2025 06:29
@a-hilaly
Copy link
Member

/test s3-controller-test

@ack-prow
Copy link

ack-prow bot commented Nov 23, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 5452297 link true /test ec2-controller-test
verify-attribution dbadfc5 link false /test verify-attribution
s3-olm-test dbadfc5 link false /test s3-olm-test
s3-controller-test dbadfc5 link true /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly a-hilaly merged commit e922bb8 into aws-controllers-k8s:main Nov 23, 2025
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants