ACK controller have duplicate CRD causing issues when using kustomize

[leofvo]

Is your feature request related to a problem?
Yes.
To understand our issue, we are using argocd and kustomize, and we have defined an argocd application that is regrouping all ACK controller we want to use.
Basically, we use IAM, RDS, S3.
We have an issue due to kustomize, when kustomize is building the yaml, it throws an error due to CRDs duplication...

The CRDs concerned are the following:
services.k8s.aws_adoptedresources.yaml
services.k8s.aws_fieldexports.yaml

Theses CRDs are present in each helm charts, and they are exactly the same..

Step to reproduce our problem
Create your kustomize file:

helmCharts:
- repo: oci://public.ecr.aws/aws-controllers-k8s
  name: s3-chart
  includeCRDs: true
  releaseName: s3
  version: 1.0.9
- repo: oci://public.ecr.aws/aws-controllers-k8s
  name: rds-chart
  includeCRDs: true
  releaseName: rds
  version: 1.1.11

Then apply:
kustomize build --enable-helm .

At this step, kustomize will fail saying that some CRDs are the same, and need to be merge or patch.

Describe the solution you'd like
Define this CRDs as helm dependencies could allow us to activate the CRD creation once.

Describe alternatives you've considered
Giving more flexibility to choose which CRDs are deployed from the helm values.

[gecube]

Hi!

Interesting thing. I really wonder how I did not notice it, as I am using FluxCD and did not run into this issue. For the more context - I am installing every chart as a separate release.

Also I would like to mention, that I had ANOTHER issue with CRDs, when upgrading Helm charts versions #2007

[ack-bot]

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[gecube]

/remove-lifecycle stale

[jon-rei]

I also ran into the same problem with ArgoCD. We use ArgoCD to deploy all our applications and use the ack-chart to enable all the controllers we want to deploy in our clusters.

ArgoCD now displays the following for our application:

Resource apiextensions.k8s.io/CustomResourceDefinition//adoptedresources.services.k8s.aws appeared 2 times among application resources.
Resource apiextensions.k8s.io/CustomResourceDefinition//fieldexports.services.k8s.aws appeared 2 times among application resources.

For us, the deployment of the controllers does not fail, but there is a warning in the application, but it would be great if the CRD deployment could be improved.

[james-callahan]

Trying to do a kustomization with multiple upstream controllers fail:

Error: accumulating resources: accumulation: may not add resource with an already registered id: CustomResourceDefinition.v1.apiextensions.k8s.io/adoptedresources.services.k8s.aws.[noNs]

[pandvan]

We're just hit the same issue.
Maybe it could be better to move shared CRDs to https://github.com/aws-controllers-k8s/ack-chart Chart and let them optional on single charts. It could be helpful to treat them as resources instead of CRDs. Many other charts are moving in this direction to allow better upgrade management by Helm, ArgoCD and other deployment tools

[gecube]

@pandvan please don’t recommend it. Moving crds to templates creates more problems than it solves. The best option could be to separate crds to a dedicated helm chart, but the versioning question arises and number of entities which you need to maintain duplicates. Maybe the only rational option would be to manage crds inside controllers itself, but it also sounds over complicated and does not give to much flexibility of cluster operators.

Many other charts are moving in this direction to allow better upgrade management by Helm, ArgoCD and other deployment tools

That many does - does not mean that it is right movement

[mmclane]

We are also seeing the issue and are using the ack-chart helm chart.

I have seen the pattern where the CRDs are moved to a separate helm chart and that is what my gut says is the right answer. It doesn't have to be all of them, just the common ones (two of them currently right?). That common chart can be a dependency for the other charts.