ACK ECR does not update Repository status when adopted

[Zurvarian]

Describe the bug
When using ACK ECR to create repositories, if adopting and existing repository, the CR is missing status fields like ackResourceMetadata or repositoryURI

Steps to reproduce
Create a new Repository with the annotation: services.k8s.aws/deletion-policy: retain and wait until it is Synced.
Delete the create Repository, the ECR counterpart should stay in place.
Re-Create the same Repository adding the annotation: services.k8s.aws/adoption-policy: adopt-or-create and wait until it Synced.

Expected outcome
The CR should have the same status fields as it would have been created anew.

Environment
N/A

• Kubernetes version 1.33
• Using EKS (yes/no), if so version? Yes, eks.21
• AWS service targeted (S3, RDS, etc.) ECR
• ACK ECR Controller v1.3.0

[github-actions]

Hello @Zurvarian 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

You can find more information about ACK on our website.

[Zurvarian]

Small update, I also noticed that the spec values are not set either.
Things like the Adopted annotation or the default values of the non-specified attributes are also missing. (E.g we don't explicitly set the Mutability of tags, and so looking at the code the Spec should be updated to MUTABLE, instead it remains nil)

[knottnt]

@Zurvarian Thanks for reporting this. I'm able to reproduce this with the below manifest. After some testing it does look like explicitly setting the spec.imageTagMutability field to MUTABLE results in the ackResourceMetadata and repositoryURI status fields being set as expected. So, that could be a workaround while we investigate this bug.

apiVersion: ecr.services.k8s.aws/v1alpha1
kind: Repository
metadata:
  name: my-adopted
  annotations:
    services.k8s.aws/deletion-policy: retain
    services.k8s.aws/adoption-policy: adopt-or-create
spec:
  name: my-adopted
  imageScanningConfiguration:
    scanOnPush: true
  encryptionConfiguration:
    encryptionType: AES256
  tags:
    - key: Environment
      value: production
    - key: Team
      value: backend