Skip to content

Conversation

@jaypipes
Copy link
Contributor

@jaypipes jaypipes commented Mar 6, 2023

We had an old Go version (1.14) and ancient deps listed in the default go.mod.tpl file. This updates to a more modern set of deps and Go version (1.19) which results in fewer iterations of go mod tidy when generating a bootstrapped controller.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We had an old Go version (1.14) and ancient deps listed in the default
go.mod.tpl file. This updates to a more modern set of deps and Go
version (1.19) which results in fewer iterations of `go mod tidy` when
generating a bootstrapped controller.

Signed-off-by: Jay Pipes <jaypipes@gmail.com>
@ack-prow ack-prow bot requested review from a-hilaly and vijtrip2 March 6, 2023 16:10
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 6, 2023

Hi @jaypipes. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+++
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@ack-prow
Copy link

ack-prow bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Mar 6, 2023
@a-hilaly
Copy link
Member

a-hilaly commented Mar 6, 2023

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2023
@ack-prow ack-prow bot merged commit d8b9a22 into aws-controllers-k8s:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants