add custom state ReplcaState

Author: rushmash91

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2025-03-14T22:49:47Z"
-  build_hash: 0ab258c51775fd52af32e649da00d57373b20869
+  build_date: "2025-03-21T01:11:17Z"
+  build_hash: 3722729cebe6d3c03c7e442655ef0846f91566a2
   go_version: go1.24.0
-  version: v0.43.2-6-g0ab258c
-api_directory_checksum: 0d5b95bdbe63c6cfc495149b7a86440c4a5fb33a
+  version: v0.43.2-7-g3722729
+api_directory_checksum: 8d795cf646566fd401b3d1642eaeb6524010c17c
 api_version: v1alpha1
 aws_sdk_go_version: v1.32.6
 generator_config_info:
-  file_checksum: 85db04e11e016a28a99058aab04767cf8345242e
+  file_checksum: 51bcf58f02c2653ddaf3d98d6d60216c04c53dfe
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -13,6 +13,13 @@ ignore:
   - TableDescription.TableClassSummary
   - CreateTableInput.ResourcePolicy
   - CreateTableInput.WarmThroughput
+custom_shapes:
+  RepicaState:
+    RegionName: string
+    RegionStatus: string
+    RegionStatusDescription: string
+    RegionStatusPercentProgress: string
+    RegionInaccessibleDateTime: string
 operations:
   UpdateGlobalTable:
     operation_type:
@@ -25,15 +32,11 @@ operations:
 resources:
   Table:
     fields:
-      Replicas:
+      ReplicationGroup:
         custom_field:
           list_of: CreateReplicationGroupMemberAction
         compare:
           is_ignored: true 
-      ReplicasDescriptions:
-        custom_field:
-          list_of: ReplicaDescription
-        is_read_only: true
       GlobalSecondaryIndexesDescriptions:
         custom_field:
           list_of: GlobalSecondaryIndexDescription
@@ -73,7 +76,7 @@ resources:
         references:
           service_name: kms
           resource: Key
-          path: Status.ACKResourceMetadata.ARN  
+          path: Status.ACKResourceMetadata.ARN
     exceptions:
       errors:
         404:

apis/v1alpha1/table.go

@@ -322,7 +322,7 @@ spec:
                     format: int64
                     type: integer
                 type: object
-              replicas:
+              replicationGroup:
                 items:
                   description: Represents a replica to be created.
                   properties:
@@ -644,7 +644,8 @@ spec:
 
                      * StreamLabel
                 type: string
-              replicasDescriptions:
+              replicas:
+                description: Represents replicas of the table.
                 items:
                   description: Contains the details of the replica.
                   properties:

apis/v1alpha1/types.go

@@ -13,6 +13,13 @@ ignore:
   - TableDescription.TableClassSummary
   - CreateTableInput.ResourcePolicy
   - CreateTableInput.WarmThroughput
+custom_shapes:
+  RepicaState:
+    RegionName: string
+    RegionStatus: string
+    RegionStatusDescription: string
+    RegionStatusPercentProgress: string
+    RegionInaccessibleDateTime: string
 operations:
   UpdateGlobalTable:
     operation_type:
@@ -25,15 +32,11 @@ operations:
 resources:
   Table:
     fields:
-      Replicas:
+      ReplicationGroup:
         custom_field:
           list_of: CreateReplicationGroupMemberAction
         compare:
           is_ignored: true 
-      ReplicasDescriptions:
-        custom_field:
-          list_of: ReplicaDescription
-        is_read_only: true
       GlobalSecondaryIndexesDescriptions:
         custom_field:
           list_of: GlobalSecondaryIndexDescription
@@ -73,7 +76,7 @@ resources:
         references:
           service_name: kms
           resource: Key
-          path: Status.ACKResourceMetadata.ARN  
+          path: Status.ACKResourceMetadata.ARN
     exceptions:
       errors:
         404:

apis/v1alpha1/zz_generated.deepcopy.go

@@ -326,7 +326,7 @@ spec:
                     format: int64
                     type: integer
                 type: object
-              replicas:
+              replicationGroup:
                 items:
                   description: Represents a replica to be created.
                   properties:
@@ -648,7 +648,8 @@ spec:
 
                      * StreamLabel
                 type: string
-              replicasDescriptions:
+              replicas:
+                description: Represents replicas of the table.
                 items:
                   description: Contains the details of the replica.
                   properties:

config/crd/bases/dynamodb.services.k8s.aws_tables.yaml

@@ -15,6 +15,7 @@ package table
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"strings"
 	"time"
@@ -51,7 +52,7 @@ var (
 		svcsdktypes.IndexStatusCreating,
 	)
 	ErrReplicaNotActive = fmt.Errorf(
-		"table replica in NOT '%v' state, cannot be modified or deleted",
+		"table replica isn't in '%v' state, cannot be modified or deleted",
 		svcsdktypes.ReplicaStatusActive,
 	)
 )
@@ -106,34 +107,16 @@ func tableHasTerminalStatus(r *resource) bool {
 	return false
 }
 
-// isTableCreating returns true if the supplied DynamodbDB table is in the process
-// of being created
-func isTableCreating(r *resource) bool {
+// canUpdateTable returns true if the supplied DynamoDB table is in a state that can be updated
+// (not creating, updating, or deleting)
+func canUpdateTable(r *resource) bool {
 	if r.ko.Status.TableStatus == nil {
 		return false
 	}
 	dbis := *r.ko.Status.TableStatus
-	return dbis == string(v1alpha1.TableStatus_SDK_CREATING)
-}
-
-// isTableDeleting returns true if the supplied DynamodbDB table is in the process
-// of being deleted
-func isTableDeleting(r *resource) bool {
-	if r.ko.Status.TableStatus == nil {
-		return false
-	}
-	dbis := *r.ko.Status.TableStatus
-	return dbis == string(v1alpha1.TableStatus_SDK_DELETING)
-}
-
-// isTableUpdating returns true if the supplied DynamodbDB table is in the process
-// of being deleted
-func isTableUpdating(r *resource) bool {
-	if r.ko.Status.TableStatus == nil {
-		return false
-	}
-	dbis := *r.ko.Status.TableStatus
-	return dbis == string(v1alpha1.TableStatus_SDK_UPDATING)
+	return dbis != string(v1alpha1.TableStatus_SDK_CREATING) &&
+		dbis != string(v1alpha1.TableStatus_SDK_UPDATING) &&
+		dbis != string(v1alpha1.TableStatus_SDK_DELETING)
 }
 
 func (rm *resourceManager) customUpdateTable(
@@ -146,21 +129,12 @@ func (rm *resourceManager) customUpdateTable(
 	exit := rlog.Trace("rm.customUpdateTable")
 	defer func(err error) { exit(err) }(err)
 
-	if isTableDeleting(latest) {
-		msg := "table is currently being deleted"
-		setSyncedCondition(desired, corev1.ConditionFalse, &msg, nil)
-		return desired, requeueWaitWhileDeleting
-	}
-	if isTableCreating(latest) {
-		msg := "table is currently being created"
-		setSyncedCondition(desired, corev1.ConditionFalse, &msg, nil)
-		return desired, requeueWaitWhileCreating
-	}
-	if isTableUpdating(latest) {
+	if !canUpdateTable(latest) {
 		msg := "table is currently being updated"
 		setSyncedCondition(desired, corev1.ConditionFalse, &msg, nil)
 		return desired, requeueWaitWhileUpdating
 	}
+
 	if tableHasTerminalStatus(latest) {
 		msg := "table is in '" + *latest.ko.Status.TableStatus + "' status"
 		setTerminalCondition(desired, corev1.ConditionTrue, &msg, nil)
@@ -234,6 +208,13 @@ func (rm *resourceManager) customUpdateTable(
 				return nil, err
 			}
 		case delta.DifferentAt("Spec.Replicas"):
+
+			if !hasStreamSpecificationWithNewAndOldImages(desired) {
+				msg := "table must have DynamoDB Streams enabled with StreamViewType set to NEW_AND_OLD_IMAGES for replica updates"
+				rlog.Debug(msg)
+				return nil, ackerr.NewTerminalError(errors.New(msg))
+			}
+
 			if err := rm.syncReplicaUpdates(ctx, latest, desired); err != nil {
 				return nil, err
 			}
@@ -572,11 +553,11 @@ func customPreCompare(
 	}
 
 	// Handle ReplicaUpdates comparison
-	if len(a.ko.Spec.Replicas) != len(b.ko.Spec.Replicas) {
-		delta.Add("Spec.Replicas", a.ko.Spec.Replicas, b.ko.Spec.Replicas)
-	} else if a.ko.Spec.Replicas != nil && b.ko.Spec.Replicas != nil {
-		if !equalReplicaArrays(a.ko.Spec.Replicas, b.ko.Spec.Replicas) {
-			delta.Add("Spec.Replicas", a.ko.Spec.Replicas, b.ko.Spec.Replicas)
+	if len(a.ko.Spec.ReplicationGroup) != len(b.ko.Spec.ReplicationGroup) {
+		delta.Add("Spec.ReplicationGroup", a.ko.Spec.ReplicationGroup, b.ko.Spec.ReplicationGroup)
+	} else if a.ko.Spec.ReplicationGroup != nil && b.ko.Spec.ReplicationGroup != nil {
+		if !equalReplicaArrays(a.ko.Spec.ReplicationGroup, b.ko.Spec.ReplicationGroup) {
+			delta.Add("Spec.ReplicationGroup", a.ko.Spec.ReplicationGroup, b.ko.Spec.ReplicationGroup)
 		}
 	}