feat: add support for Capability resource #189
Conversation
michaelhtm
force-pushed
the
feat/capability
branch
2 times, most recently
from
c07a10f to
cc978e4
Compare
michaelhtm
force-pushed
the
feat/capability
branch
4 times, most recently
from
47003aa to
2f9e4b5
Compare
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
michaelhtm
force-pushed
the
feat/capability
branch
2 times, most recently
from
75529b0 to
8fa4cc7
Compare
| // Services use. You cannot edit or delete tag keys or values with this prefix. | ||
| // Tags with this prefix do not count against your tags per resource limit. | ||
| Tags map[string]*string `json:"tags,omitempty"` | ||
| Type *string `json:"type_,omitempty"` |
There was a problem hiding this comment.
does this need to be renamed type
There was a problem hiding this comment.
this one is not necessary..it's not used when generating CRDs
michaelhtm
force-pushed
the
feat/capability
branch
2 times, most recently
from
5a5eb4d to
b967358
Compare
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
michaelhtm
force-pushed
the
feat/capability
branch
from
b967358 to
4d9642b
Compare
|
/test eks-verify-code-gen |
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Description of changes:
Add support for EKS Capabilities
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.