Update hooks for Go v2 support and Migrates tests to use acktest framework exclusively
#151
Conversation
rushmash91
force-pushed
the
test-revamp
branch
6 times, most recently
from
a1f2e5b to
351b97d
Compare
|
/test elasticache-kind-e2e |
rushmash91
force-pushed
the
test-revamp
branch
from
351b97d to
53d3d50
Compare
|
/test elasticache-kind-e2e |
rushmash91
force-pushed
the
test-revamp
branch
5 times, most recently
from
8d031c9 to
36331ff
Compare
|
/test elasticache-kind-e2e |
rushmash91
force-pushed
the
test-revamp
branch
2 times, most recently
from
4eb4f67 to
35f7847
Compare
|
/test elasticache-kind-e2e |
1 similar comment
|
/test elasticache-kind-e2e |
rushmash91
force-pushed
the
test-revamp
branch
5 times, most recently
from
511211a to
338514f
Compare
There was a problem hiding this comment.
Great job on this @rushmash91 🚀🚀🚀
I left a few comments..
cc: @a-hilaly
templates/hooks/replication_group/sdk_file_end_set_output_post_populate.go.tpl
Outdated
Show resolved
Hide resolved
config/crd/bases/elasticache.services.k8s.aws_cachesubnetgroups.yaml
Outdated
Show resolved
Hide resolved
rushmash91
force-pushed
the
test-revamp
branch
from
338514f to
bb1437b
Compare
rushmash91
force-pushed
the
test-revamp
branch
from
bb1437b to
b0b496d
Compare
rushmash91
force-pushed
the
test-revamp
branch
from
b0b496d to
19994cf
Compare
|
@rushmash91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test elasticache-kind-e2e |
rushmash91
changed the title
Go v2 support and Migrates tests to use acktest framework exclusively
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This PR modernizes the ElastiCache controller by updating all controller hooks for
AWS SDK Go v2 compatibilityand consolidating the testing infrastructure. The testing framework has been completely migrated from the separate ElastiCache testing framework to use the standardacktestframework exclusively, removing themockerydependency and eliminating previously skipped flaky tests that were causing instability. These changes reduced test execution time from approximately 3 hours to 1 hour through framework consolidation while improving test reliability by standardizing on maintained testing infrastructure.By consolidating on the acktest framework, this change eliminates the maintenance burden of supporting multiple testing approaches and leverages the actively maintained ACK testing infrastructure. The removal of flaky tests that were previously skipped means the test suite now provides more reliable feedback on code changes, while the significant reduction in test execution time improves developer productivity and reduces
CI/CDinfrastructure costs. This refactoring establishes a more maintainable and efficient foundation for ongoing ElastiCache controller development.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.