Enable Passwords field (upon creation) #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumargauravsharma
approved these changes
Jul 1, 2021
jaypipes
approved these changes
Jul 1, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: echen-98, jaypipes, kumargauravsharma, nmvk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
echen-98
force-pushed
the
user-support
branch
2 times, most recently
from
2a2b1d8 to
a82e4e4
Compare
Contributor
Author
|
/test elasticache-kind-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Use recent changes in code-generator to allow creation of a User with the
Passwordsfield as a slice of k8s secrets. Test included.Currently, updating the
Passwordsfield is not supported (i.e. it's ignored in delta comparison and not placed in the Update payload). This is because in general, we cannot tell when the desired passwords have changed, other than cases where the changes are visible in theAuthenticationfield.Figuring out the update behavior will come later (likely requires changes in common repos).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.