regenerate code, fix replication group delete templates, upgrade to runtime 0.6.0 #42
Conversation
| resp, err = rm.sdkapi.DeleteReplicationGroupWithContext(ctx, input) | ||
| rm.metrics.RecordAPICall("DELETE", "DeleteReplicationGroup", err) | ||
| // delete call successful | ||
| if err == nil { | ||
| if foundResource, err := rm.sdkFind(ctx, r); err != ackerr.NotFound { | ||
| if isDeleting(foundResource) { | ||
| return requeueWaitWhileDeleting | ||
| } | ||
| return err | ||
| } | ||
| return r, requeueWaitWhileDeleting |
There was a problem hiding this comment.
This logic does not take values from resp.ReplicationGroup.
Please add a comment here about this behavior in the code.
It is expected to work fine, as the next reconciler run (after requeue wait interval) will fetch latest state of it and lines 1389-1390 above will ensure that the correct status is updated inside reconciler->patchResource.
| invoke: Delete | ||
| expect: # for the delete case we don't expect a new latest state or a non-nil error | ||
| latest_state: nil | ||
| expect: |
There was a problem hiding this comment.
As there is no call to sdkFind() inside sdkDelete(), there is no need to mock DescribeReplicationGroupsWithContext, ListAllowedNodeTypeModifications and ListAllowedNodeTypeModifications service APIs.
|
@kumargauravsharma addressed both comments |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: echen-98, kumargauravsharma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Description of changes:
Please check if the resulting
sdkDeleteis as intended.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.