Skip to content

Conversation

@vijtrip2
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#1019

Description of changes:

  • Main changes in sdk_file_end.go.tpl , others files are auto-generated using latest code-generator and latest runtime
  • Previously the method was named set{{ $outputShape.ShapeName }}Output which caused the method name to be "setCreateReplicationGroupOutputOutput" and existing custom_update_api.go started failing. See #61
  • I do not know why elasticache team did not chose to name the method statically as setReplicationGroupOutput but templatized it.
  • Keep the existing templatization in mind, I updated the template to produce methodName and parameter as earlier, which compiles successfully with custom_update_api.go
  • Note: This regression occured because GetOutputShape started to correctly return Output shape as part of this commit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ack-bot
Copy link
Collaborator

ack-bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, nmvk, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,nmvk,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vijtrip2 vijtrip2 merged commit 35678e6 into aws-controllers-k8s:main Oct 12, 2021
@vijtrip2 vijtrip2 deleted the new-release branch October 12, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants