Rename ReplicationGroupDescription to Description

[RedbackThomson]

Issue #, if available: aws-controllers-k8s/community#1250

Description of changes:
Renamed the CreateReplicationGroup and ModifyReplicationGroup input field ReplicationGroupDescription to simply be Description, to match the DescribeReplicationGroups output shape

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jaypipes]

👍

[jaypipes]

heh, nice spelling catch :)

[vijtrip2]

/test elasticache-kind-e2e

[vijtrip2]

/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RedbackThomson,jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elops]

I installed controller today. First v0.0.25 then went back to v0.0.24 because of this

$ helm list -n ack-system | grep elastica
elasticache-chart-1684933362	ack-system	1       	2023-05-24 20:02:51.492596261 +0700 +07	deployed	elasticache-chart-v0.0.24	v0.0.24
$ kubectl explain ReplicationGroup.spec |  grep  replicationGroupDescription 
   replicationGroupDescription	<string> -required-

I had helm chart working and all of a sudden when I installed new cluster today it was complaining about description and wanting replicationGroupDescription

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(ReplicationGroup.spec): unknown field "description" in aws.k8s.services.elasticache.v1alpha1.ReplicationGroup.spec, ValidationError(ReplicationGroup.spec): missing required field "replicationGroupDescription" in aws.k8s.services.elasticache.v1alpha1.ReplicationGroup.spec]

[jaypipes]

@elops interesting. the ReplicationGroup's CRD still lists the field as Description:

elasticache-controller/config/crd/bases/elasticache.services.k8s.aws_replicationgroups.yaml

Lines 162 to 164 in c318280

	description:
	description: A user-created description for the replication group.
	type: string

and that is what is listed in the required fields:

elasticache-controller/config/crd/bases/elasticache.services.k8s.aws_replicationgroups.yaml

Line 401 in c318280

- description

@RedbackThomson any idea (from a Helm perspective) that this might have changed?

[elops]

Sorry guys, I figured it out. I installed actually first version 0.0.9 which was super old and CRDs from that one prevailed until I deleted them manually and installed more recent version of controller.

[jaypipes]

No worries @elops, it happens! :) Glad to hear you figured it out!