Skip to content

bring controller to runtime v0.20.1 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

bring controller to runtime v0.20.1 #98

merged 1 commit into from
Oct 24, 2022

Conversation

@jaypipes
Copy link
Contributor

Brings ACK runtime v0.20.1 and aws-sdk-go v1.44.93 to Elasticache controller.

Needed to modify the config/iam/KMS-policy-template.json to include the
now-necessary CloudWatch Logs permissions that the testing framework uses.

Signed-off-by: Jay Pipes jaypipes@gmail.com

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

@jaypipes
bring controller to runtime v0.20.1
054f714 
Brings ACK runtime v0.20.1 and aws-sdk-go v1.44.93 to Elasticache
controller.

Needed to modify the `config/iam/KMS-policy-template.json` to include
the now-necessary CloudWatch Logs permissions that the testing framework
uses.

Signed-off-by: Jay Pipes <jaypipes@gmail.com>
@RedbackThomson
Copy link
Contributor

I don't understand what this KMS-policy-template.json is? Is it because we need a mix of inline policies and recommended policy ARNs to install the permissions for the controller? Can we not just do it all within an inline policy?

@jaypipes
Copy link
Contributor Author

I don't understand what this KMS-policy-template.json is? Is it because we need a mix of inline policies and recommended policy ARNs to install the permissions for the controller? Can we not just do it all within an inline policy?

@RedbackThomson it is specifically for the e2e testing that this controller uses...

@a-hilaly
Copy link
Member

Ohhh i just saw this doc https://github.com/aws-controllers-k8s/elasticache-controller/blob/main/config/iam/README.md#kms-key-management-service

@a-hilaly
Copy link
Member

@kumargauravsharma The failing tests i pinged you about also appears in this PR. Checkout https://prow.ack.aws.dev/view/s3/ack-prow-logs/pr-logs/pull/aws-controllers-k8s_elasticache-controller/98/elasticache-recommended-policy-test/1583202603003547648

@jaypipes
Copy link
Contributor Author

/test elasticache-recommended-policy-test

a-hilaly
a-hilaly approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit a318922 into aws-controllers-k8s:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

@kumargauravsharma kumargauravsharma Awaiting requested review from kumargauravsharma

@nmvk nmvk Awaiting requested review from nmvk

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaypipes @RedbackThomson @a-hilaly @ack-bot